[PATCH] D147998: [RISCV] Support vector strict_fsetcc/fsetccs.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 00:43:42 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:7464
+  } else {
+    Mask = getAllOnesMask(ContainerInVT, VL, DL, DAG);
+  }
----------------
I think you can do 

```
auto [Mask, VL] = getDefaultVLOps(InVT, ContainerInVT, DL, DAG, Subtarget);
```

before the if. Then you don't need this else. The mask will have already been set to all ones by getDefaultVLOps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147998/new/

https://reviews.llvm.org/D147998



More information about the llvm-commits mailing list