[PATCH] D147998: [RISCV] Support vector strict_fsetcc/fsetccs.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:7407
+  // RVV VMFEQ/VMFNE ignores qNan, so we expand strict_fsetccs with OEQ/UNE
+  // conditon code.
+  if (Opc == ISD::STRICT_FSETCCS) {
----------------
conditon -> condition


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vfcmp-constrained-sdnode.ll:49
+; CHECK-NEXT:    vmand.mm v0, v11, v10
+; CHECK-NEXT:    vmflt.vv v0, v9, v8, v0.t
+; CHECK-NEXT:    ret
----------------
I think maybe this vmflt.vv needs to use mask undisturbed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147998/new/

https://reviews.llvm.org/D147998