[PATCH] D148032: [symbolizer] Change error message if module not found

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 00:11:28 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.

One minor suggestion. Otherwise, looks good to me.



================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:68
 
+using ErrorHandler = void (*)(const ErrorInfoBase &, StringRef);
+
----------------
I think it's more normal to use `llvm::function_ref` rather than a function pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148032/new/

https://reviews.llvm.org/D148032



More information about the llvm-commits mailing list