[PATCH] D148032: [symbolizer] Change error message if module not found
Serge Pavlov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 12 23:48:04 PDT 2023
sepavloff added a comment.
Thanks!
================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:73
raw_ostream &OS;
- raw_ostream &ES;
+ MessagePrinter MsgPrinter;
PrinterConfig Config;
----------------
MaskRay wrote:
> MaskRay wrote:
> > This is used to print error messages to `errs()`, not other types of messages. Shall we name this `ErrorPrinter`?
> ErrorHandler may be better than ErrorPrinter.
>
> llvm-readobj has a WarningHandler.
Renamed to `ErrorHandler`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148032/new/
https://reviews.llvm.org/D148032
More information about the llvm-commits
mailing list