[PATCH] D147864: ValueTracking: Address todo for nan fmul handling in computeKnownFPClass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D147864#4263022 <https://reviews.llvm.org/D147864#4263022>, @nikic wrote:

> Could you please also add test coverage for the denormal handling?

I did but somehow it's not in the diff



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4468
     KnownFPClass KnownLHS, KnownRHS;
-    computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan | fcInf,
+    computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan | fcInf | fcZero,
                         KnownRHS, Depth + 1, Q, TLI);
----------------
nikic wrote:
> Don't we also need to pass in fcSubnormal as well for these?
It's not strictly necessary since we're not really making use of these hints yet 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147864/new/

https://reviews.llvm.org/D147864