[PATCH] D147864: ValueTracking: Address todo for nan fmul handling in computeKnownFPClass
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 12 14:02:20 PDT 2023
nikic added a comment.
Could you please also add test coverage for the denormal handling?
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4468
KnownFPClass KnownLHS, KnownRHS;
- computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan | fcInf,
+ computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan | fcInf | fcZero,
KnownRHS, Depth + 1, Q, TLI);
----------------
Don't we also need to pass in fcSubnormal as well for these?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147864/new/
https://reviews.llvm.org/D147864
More information about the llvm-commits
mailing list