[PATCH] D148149: [TTI] getMinMaxReductionCost - add std::optional<FastMathFlags> argument

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1395
       VectorType *Ty, VectorType *CondTy, bool IsUnsigned,
+      std::optional<FastMathFlags> FMF = std::nullopt,
       TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput) const;
----------------
nikic wrote:
> Why do we need the std::optional wrapper? FMF already has a value to represent no FMF.
I was wondering the same thing - I matched what was already done by the sibling methods - I'll investigate stripping it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148149/new/

https://reviews.llvm.org/D148149