[PATCH] D148149: [TTI] getMinMaxReductionCost - add std::optional<FastMathFlags> argument

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 12:07:35 PDT 2023


nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1395
       VectorType *Ty, VectorType *CondTy, bool IsUnsigned,
+      std::optional<FastMathFlags> FMF = std::nullopt,
       TTI::TargetCostKind CostKind = TTI::TCK_RecipThroughput) const;
----------------
Why do we need the std::optional wrapper? FMF already has a value to represent no FMF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148149/new/

https://reviews.llvm.org/D148149



More information about the llvm-commits mailing list