[PATCH] D147835: [X86][mem-fold] Speed up test by not re-generating the .inc file

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 06:38:16 PDT 2023


skan added a comment.

In D147835#4257893 <https://reviews.llvm.org/D147835#4257893>, @thakis wrote:

> Is using LLVM_OPTIMIZED_TABLEGEN an option for you?

@thakis Yes, it's an option to me for most cases, thanks. Even 14 seconds is acceptable for me. I created this patch just for a better speed not for a concern. I'm fine with your revert. BTW, should we add back the `REQUIRES: x86-registered-target` in the test? I don't think users care about the test when x86 is not the build targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147835/new/

https://reviews.llvm.org/D147835



More information about the llvm-commits mailing list