[PATCH] D147835: [X86][mem-fold] Speed up test by not re-generating the .inc file
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 11 06:17:48 PDT 2023
thakis added a comment.
(To answer your question, the path as-is expands to `llvm-project/out/gn/lib/Target/X86/X86GenFoldTables.inc` but the file is at `out/gn/gen/llvm/lib/Target/X86/X86GenFoldTables.inc`. But I'd argue that tests shouldn't make assumptions about the layout of stuff in the build dir – managing that is lit's job. So if we must do this, I think we should add a substitution for this – `llvm_gen_dir` maybe, but even then you'd hardcode the layout of stuff below that dir. Maybe just `llvm_x86_gen_fold_tables_inc_path`. See llvm/test/lit.site.cfg.py.in.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147835/new/
https://reviews.llvm.org/D147835
More information about the llvm-commits
mailing list