[PATCH] D142756: AMDGPU: Try to select fneg modifier from xor

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 04:14:24 PDT 2023


arsenm added a comment.

ping



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:2602
+  } else {
+    Src = stripBitcast(Src);
+    if (Src.getOpcode() == ISD::XOR) {
----------------
Pierre-vh wrote:
> Can we just do the stripBitcast call earlier? (at `Src = In`)
> That way it simplifies the condition a bit (you can have a if/else if)
> 
It would work but adds code in the common case


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142756/new/

https://reviews.llvm.org/D142756



More information about the llvm-commits mailing list