[llvm] f5f04a5 - [Pipelines] Use isLTOPreLink() helper in more places (NFC)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 11 04:13:47 PDT 2023
Author: Nikita Popov
Date: 2023-04-11T13:13:36+02:00
New Revision: f5f04a52b5146d124d7dbda93aeba09e19bf8a44
URL: https://github.com/llvm/llvm-project/commit/f5f04a52b5146d124d7dbda93aeba09e19bf8a44
DIFF: https://github.com/llvm/llvm-project/commit/f5f04a52b5146d124d7dbda93aeba09e19bf8a44.diff
LOG: [Pipelines] Use isLTOPreLink() helper in more places (NFC)
Added:
Modified:
llvm/lib/Passes/PassBuilderPipelines.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Passes/PassBuilderPipelines.cpp b/llvm/lib/Passes/PassBuilderPipelines.cpp
index 925bb4b7295c..943823c5227c 100644
--- a/llvm/lib/Passes/PassBuilderPipelines.cpp
+++ b/llvm/lib/Passes/PassBuilderPipelines.cpp
@@ -990,8 +990,7 @@ PassBuilder::buildModuleSimplificationPipeline(OptimizationLevel Level,
MPM.addPass(RequireAnalysisPass<ProfileSummaryAnalysis, Module>());
// Do not invoke ICP in the LTOPrelink phase as it makes it hard
// for the profile annotation to be accurate in the LTO backend.
- if (Phase != ThinOrFullLTOPhase::ThinLTOPreLink &&
- Phase != ThinOrFullLTOPhase::FullLTOPreLink)
+ if (!isLTOPreLink(Phase))
// We perform early indirect call promotion here, before globalopt.
// This is important for the ThinLTO backend phase because otherwise
// imported available_externally functions look unreferenced and are
@@ -1024,8 +1023,7 @@ PassBuilder::buildModuleSimplificationPipeline(OptimizationLevel Level,
IPSCCPOptions(/*AllowFuncSpec=*/
Level != OptimizationLevel::Os &&
Level != OptimizationLevel::Oz &&
- Phase != ThinOrFullLTOPhase::ThinLTOPreLink &&
- Phase != ThinOrFullLTOPhase::FullLTOPreLink)));
+ !isLTOPreLink(Phase))));
// Attach metadata to indirect call sites indicating the set of functions
// they may target at run-time. This should follow IPSCCP.
@@ -1234,8 +1232,7 @@ void PassBuilder::addVectorPasses(OptimizationLevel Level,
ModulePassManager
PassBuilder::buildModuleOptimizationPipeline(OptimizationLevel Level,
ThinOrFullLTOPhase LTOPhase) {
- const bool LTOPreLink = (LTOPhase == ThinOrFullLTOPhase::ThinLTOPreLink ||
- LTOPhase == ThinOrFullLTOPhase::FullLTOPreLink);
+ const bool LTOPreLink = isLTOPreLink(LTOPhase);
ModulePassManager MPM;
// Run partial inlining pass to partially inline functions that have
More information about the llvm-commits
mailing list