[PATCH] D147832: [libcxx] Introduce clang::lto_visibility_public attribute

Mark de Wever via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 8 04:03:51 PDT 2023


Mordante requested changes to this revision.
Mordante added a comment.

Next to @philnik's issues I have a large issue with the lack of documentation. Our visibility macros are already not very well documented, adding more without any documentation seems like a bad idea.
Especially there is no explanation which `friend` declarations need this markup and which don't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147832/new/

https://reviews.llvm.org/D147832



More information about the llvm-commits mailing list