[PATCH] D147832: [libcxx] Introduce clang::lto_visibility_public attribute

[Nikolas Klauser via Phabricator via llvm-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

I've got a few problems with this patch (in no particular order):

1. It makes our visibility annotations even more complicated. It is already way to complicated, we should avoid making it even worse.
2. You say you build with `-D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -fvisibility=hidden` which AFAICT defeats the purpose of a shared library, since it wouldn't export a single symbol.
3. This is a completely untested configuration, which means it will regress (which is already a problem with the current visibility annotations)

My biggest concern right now is (2).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147832/new/

https://reviews.llvm.org/D147832