[llvm] 2ffdfb5 - [X86] Fix problem in D147541

Phoebe Wang via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 7 07:02:23 PDT 2023


Author: Phoebe Wang
Date: 2023-04-07T22:02:16+08:00
New Revision: 2ffdfb5f9dff92b10aae1d852ee3935ad90d36d1

URL: https://github.com/llvm/llvm-project/commit/2ffdfb5f9dff92b10aae1d852ee3935ad90d36d1
DIFF: https://github.com/llvm/llvm-project/commit/2ffdfb5f9dff92b10aae1d852ee3935ad90d36d1.diff

LOG: [X86] Fix problem in D147541

Differential Revision: https://reviews.llvm.org/D147775

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86FixupInstTuning.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86FixupInstTuning.cpp b/llvm/lib/Target/X86/X86FixupInstTuning.cpp
index 5da5b91653be4..4afd6007e872f 100644
--- a/llvm/lib/Target/X86/X86FixupInstTuning.cpp
+++ b/llvm/lib/Target/X86/X86FixupInstTuning.cpp
@@ -154,8 +154,8 @@ bool X86FixupInstTuningPass::processInstruction(
     return true;
   };
 
-  // `vunpcklpd/vmovlhps r, r` -> `vshufps r, r, 0x44`
-  // `vunpckhpd/vmovlhps r, r` -> `vshufps r, r, 0xee`
+  // `vunpcklpd/vmovlhps r, r` -> `vshufpd r, r, 0x00`
+  // `vunpckhpd/vmovlhps r, r` -> `vshufpd r, r, 0xff`
   // `vunpcklpd r, r, k` -> `vshufpd r, r, 0x00`
   // `vunpckhpd r, r, k` -> `vshufpd r, r, 0xff`
   // iff `vshufps` is faster than `vunpck{l|h}pd`. Otherwise stick with
@@ -234,12 +234,12 @@ bool X86FixupInstTuningPass::processInstruction(
     // processors where its safe.
   case X86::MOVLHPSrr:
   case X86::UNPCKLPDrr:
-    return ProcessUNPCKLPDrr(X86::SHUFPSrri);
+    return ProcessUNPCKLPDrr(X86::SHUFPDrri);
   case X86::VMOVLHPSrr:
   case X86::VUNPCKLPDrr:
-    return ProcessUNPCKLPDrr(X86::VSHUFPSrri);
+    return ProcessUNPCKLPDrr(X86::VSHUFPDrri);
   case X86::VUNPCKLPDYrr:
-    return ProcessUNPCKLPDrr(X86::VSHUFPSYrri);
+    return ProcessUNPCKLPDrr(X86::VSHUFPDYrri);
     // VMOVLHPS is always 128 bits.
   case X86::VMOVLHPSZrr:
   case X86::VUNPCKLPDZ128rr:


        


More information about the llvm-commits mailing list