[PATCH] D147721: [AMDGPU] Fix a case of updating LiveIntervals in SIOptimizeExecMaskingPreRA

[Carl Ritson via Phabricator via llvm-commits]

critson added a comment.

I assume D129208 <https://reviews.llvm.org/D129208> is the test case for this, so it does not need any new tests?



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:109
 //    %sel = V_CNDMASK_B32_e64 0, 1, %cc
-//    %cmp = V_CMP_NE_U32 1, %1
+//    %cmp = V_CMP_NE_U32 1, %sel
 //    $vcc = S_AND_B64 $exec, %cmp
----------------
Presumably this is just fixing an error in the original comment, i.e. NFC?


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:303
+        LIS->shrinkToUses(SelLI);
+      }
     }
----------------
I take it we cannot simply move the first `LIS->shrinkToUses(SelLI);` after the `if` because the `IsDead` query depends on it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147721/new/

https://reviews.llvm.org/D147721