[PATCH] D147740: [NFC][llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 6 23:06:20 PDT 2023
davidxl added inline comments.
================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:520
/// This should only be needed for md5 profiles.
- std::unordered_set<std::string> MD5NameBuffer;
+ std::list<std::string> MD5NameBuffer;
----------------
why changing it to list?
================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:658
+
+ /// Read the whole name table consists of ULEB128 encoded MD5 values.
+ std::error_code readMD5NameTable();
----------------
How effective is MD5 compacting with ULEB128 ? Why not use fixed length rep to save some computation time?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147740/new/
https://reviews.llvm.org/D147740
More information about the llvm-commits
mailing list