[PATCH] D147740: [NFC][llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed

Thu Apr 6 22:42:03 PDT 2023

davidxl added a comment.

In D147740#4250545 <https://reviews.llvm.org/D147740#4250545>, @aeubanks wrote:

> as somebody with very little context for this, is it possible to use faster hashing algorithms?

faster hashing may help, but I think the intention of the patch is to eliminate unnecessary computation completely.

================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:635
+    // consistent with the profile map's key.
+    // If non-context function is already MD5 string, do not hash again.
+    uint64_t Hash;
----------------
how often is the name already MD5 string?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147740/new/

https://reviews.llvm.org/D147740