[PATCH] D147664: [compiler-rt] [test] Only pass -incremental:no to the linker for MSVC/clang-cl

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: compiler-rt/test/profile/lit.cfg.py:26-30
+target_is_msvc = bool(re.match(r'.*-windows-msvc$', config.target_triple))
+
 if config.host_os in ['Linux']:
   extra_link_flags = ["-ldl"]
+elif target_is_msvc:
----------------
phosek wrote:
> Since this is only used once, you could also consider inlining it, but either way is fine.
Yeah - although I think I prefer keeping it separate, for similarity with the other files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147664/new/

https://reviews.llvm.org/D147664