[PATCH] D147664: [compiler-rt] [test] Only pass -incremental:no to the linker for MSVC/clang-cl

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 19:27:33 PDT 2023


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/test/profile/lit.cfg.py:26-30
+target_is_msvc = bool(re.match(r'.*-windows-msvc$', config.target_triple))
+
 if config.host_os in ['Linux']:
   extra_link_flags = ["-ldl"]
+elif target_is_msvc:
----------------
Since this is only used once, you could also consider inlining it, but either way is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147664/new/

https://reviews.llvm.org/D147664



More information about the llvm-commits mailing list