[PATCH] D147654: [OpenMP] Add tool dependencies in runtimes mode

[Joseph Huber via Phabricator via llvm-commits]

jhuber6 marked an inline comment as done.
jhuber6 added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:386
+    foreach(dep opt llvm-link llvm-extract clang clang-offload-packager)
+      if(TARGET ${dep} AND OPENMP_ENABLE_LIBOMPTARGET)
+        list(APPEND extra_deps ${dep})
----------------
tra wrote:
> Should `AND OPENMP_ENABLE_LIBOMPTARGET)` be moved to the top-level `if`?
These dependencies are only relevant for `libomptarget`. So if we're only building `libomp` they can be ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147654/new/

https://reviews.llvm.org/D147654