[PATCH] D147654: [OpenMP] Add tool dependencies in runtimes mode

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits.



================
Comment at: llvm/runtimes/CMakeLists.txt:386
+    foreach(dep opt llvm-link llvm-extract clang clang-offload-packager)
+      if(TARGET ${dep} AND OPENMP_ENABLE_LIBOMPTARGET)
+        list(APPEND extra_deps ${dep})
----------------
Should `AND OPENMP_ENABLE_LIBOMPTARGET)` be moved to the top-level `if`?


================
Comment at: llvm/runtimes/CMakeLists.txt:388
+        list(APPEND extra_deps ${dep})
+      endif()
+    endforeach()
----------------
Nit: stray <TAB> character.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147654/new/

https://reviews.llvm.org/D147654