[PATCH] D147456: [AutoFDO] Stale profile matching(part 1)

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:1247
+
+  /// Location mappings generated by stale profile matching.
+  ///
----------------
nit: "generated by" -> "used for"


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:448
   SampleProfileMap FlattenedProfiles;
+  // The output of stale profile matching. For each function, the matching
+  // algorithm generates a map, each entry is a mapping meaning the location
----------------
nit: For each function, the matcher generates a map, of which each entry is a mapping from the location
of current build to the location in the profile.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:451
+  // of current build is matched to the location in the profile.
+  StringMap<LocToLocMap> FuncToMatchingsMap;
 
----------------
Where is this DS populated? Is it in a separate patch?


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2197
+  // Detect profile mismatch for profile staleness metrics report.
+  detectProfileMismatch(FS, MatchedCallsiteLocs);
 }
----------------
Condition this under `ReportProfileStaleness || PersistProfileStaleness` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147456/new/

https://reviews.llvm.org/D147456