[PATCH] D145872: TableGen: Let expressions available to list subscripts and list slices

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a comment.

FYI, `list[m-n]` is used in 77 lines;
`list[m - n]` is not used!

  clang/include/clang/Basic/riscv_vector.td |   4
  llvm/lib/Target/ARM/ARMScheduleA57.td     | 118
  llvm/lib/Target/ARM/ARMScheduleA9.td      |  32
  3 files changed, 77 insertions(+), 77 deletions(-)

We could revise them, though, I think we don't need to do.

Bitslices are used in many (hundreds? thousands?) places, as you know, and fixing them would be ugly due to replacing one character `-` to three characters `...`.



================
Comment at: llvm/docs/TableGen/ProgRef.rst:347-348
+               :| `Value` "..." `Value`
+               :| `Value` "-" `Value`
+               :| `Value` `TokInteger`
 
----------------
nhaehnle wrote:
> Should the "a-b" syntax be supported here at all? It may be time to get serious about deprecating it. Excising all the uses of "a-b" for bit slices would be tough, but I'd think that with lists we're in a better position?
We could deprecate them here, though, I think we may leave old syntax,
if `TGParser::ParseSliceElement()` would be applied also to bitslice.

Deprecating would not gain the big win, I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145872/new/

https://reviews.llvm.org/D145872