[PATCH] D145872: TableGen: Let expressions available to list subscripts and list slices

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 08:31:37 PDT 2023


nhaehnle added a comment.

I haven't looked at the implementation, but the overall idea seems quite reasonable.



================
Comment at: llvm/docs/TableGen/ProgRef.rst:347-348
+               :| `Value` "..." `Value`
+               :| `Value` "-" `Value`
+               :| `Value` `TokInteger`
 
----------------
Should the "a-b" syntax be supported here at all? It may be time to get serious about deprecating it. Excising all the uses of "a-b" for bit slices would be tough, but I'd think that with lists we're in a better position?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145872/new/

https://reviews.llvm.org/D145872



More information about the llvm-commits mailing list