[PATCH] D147536: [GlobalISel] Improve stack slot tracking in dbg.values

Tue Apr 4 10:25:15 PDT 2023

aprantl added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/debug-insts.ll:41
+; CHECK: DBG_VALUE %[[stack_slot]], 0, !17, !DIExpression(), debug-location !18
   call void @llvm.dbg.value(metadata ptr %addr, i64 0, metadata !17, metadata !DIExpression(DW_OP_deref)), !dbg !18
 ; CHECK: DBG_VALUE 123, 0, !17, !DIExpression(), debug-location !18
----------------
fdeazeve wrote:
> what is this meaning of this dbg.value with 4 arguments? I can't find it anywhere in the docs
This is an old form of dbg.value with an offset field. Let's update this to the 3 argument form by dropping it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147536/new/

https://reviews.llvm.org/D147536