[PATCH] D146632: [PowerPC] Fix the xxperm swap requirements

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/xxperm-swap.ll:1
+; RUN: llc -verify-machineinstrs -mcpu=pwr9 -ppc-asm-full-reg-names \
+; RUN:   -ppc-vsr-nums-as-vr -mtriple=powerpc64le-unknown-linux-gnu < %s | \
----------------
Nit: it appears that the checks were produced bu `update_llc_test_checks.py` yet the comment saying so at the top of the file is not present (removed?). If you're using it to produce the checks, please leave it in place as it signals to future maintainers that it is safe to use it to update the test if needed.


================
Comment at: llvm/test/CodeGen/PowerPC/xxperm-swap.ll:96
+
+attributes #0 = { mustprogress nofree norecurse nosync nounwind willreturn memory(none) uwtable "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="pwr9" "target-features"="+altivec,+bpermd,+crbits,+crypto,+direct-move,+extdiv,+htm,+isa-v206-instructions,+isa-v207-instructions,+isa-v30-instructions,+power8-vector,+power9-vector,+quadword-atomics,+vsx,-privileged,-rop-protect,-spe" }
----------------
stefanp wrote:
> nit:
> See if you can cut this list down. There are a lot of tests that have only required `nounwind`. 
> After you cut down the list make sure that the test still passes.
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146632/new/

https://reviews.llvm.org/D146632