[PATCH] D146632: [PowerPC] Fix the xxperm swap requirements
Stefan Pintilie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 3 13:35:37 PDT 2023
stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.
I have only one nit and that can be fixed on commit.
Otherwise LGTM.
================
Comment at: llvm/test/CodeGen/PowerPC/xxperm-swap.ll:96
+
+attributes #0 = { mustprogress nofree norecurse nosync nounwind willreturn memory(none) uwtable "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="pwr9" "target-features"="+altivec,+bpermd,+crbits,+crypto,+direct-move,+extdiv,+htm,+isa-v206-instructions,+isa-v207-instructions,+isa-v30-instructions,+power8-vector,+power9-vector,+quadword-atomics,+vsx,-privileged,-rop-protect,-spe" }
----------------
nit:
See if you can cut this list down. There are a lot of tests that have only required `nounwind`.
After you cut down the list make sure that the test still passes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146632/new/
https://reviews.llvm.org/D146632
More information about the llvm-commits
mailing list