[PATCH] D110900: Triple: Add RedHat vendor
Aaron Puchert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 2 15:45:22 PDT 2023
aaronpuchert added inline comments.
================
Comment at: llvm/include/llvm/TargetParser/Triple.h:579
+ case Triple::UnknownEnvironment:
+ return getVendor() == RedHat;
+ default:
----------------
hvdijk wrote:
> In D110900#4160169 you suggested that this should be done for SUSE as well, do you still think so?
Yes, in fact we ship with a [patch](https://build.opensuse.org/package/view_file/devel:tools:compiler/llvm16/llvm-suse-implicit-gnu.patch) that does that in openSUSE now. It mostly works without that, but some things were missing, see D110900#4160110.
If we can agree on this, I'd open a separate change on top of this for `SUSE`. (Unless @tstellar would like to include it right away.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110900/new/
https://reviews.llvm.org/D110900
More information about the llvm-commits
mailing list