[PATCH] D110900: Triple: Add RedHat vendor

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added a comment.

In D110900#3044136 <https://reviews.llvm.org/D110900#3044136>, I suggested another approach that should reduce the number of file system accesses, which you implemented in D110900#3044545 <https://reviews.llvm.org/D110900#3044545> (D111207 <https://reviews.llvm.org/D111207>). Apologies for never responding to that; at first glance the way you implemented that looks like it increases the number of file system accesses, and I don't think we should do that. Given that the only implemented alternative is this one, I'm not going to argue against this.



================
Comment at: llvm/include/llvm/TargetParser/Triple.h:579
+    case Triple::UnknownEnvironment:
+        return getVendor() == RedHat;
+    default:
----------------
In D110900#4160169 you suggested that this should be done for SUSE as well, do you still think so?


================
Comment at: llvm/lib/TargetParser/Triple.cpp:199
   case SUSE: return "suse";
+  case RedHat: return "redhat";
   }
----------------
This list was in alphabetical order and should probably remain so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110900/new/

https://reviews.llvm.org/D110900