[PATCH] D147368: [LoongArch] Optimize bitwise and with immediates

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 1 00:39:44 PDT 2023


benshi001 added a comment.

In D147368#4238148 <https://reviews.llvm.org/D147368#4238148>, @xen0n wrote:

> Good catch, thanks!
>
> IMO you could include as comments your explanations to existing cases where this optimization has not taken place (e.g. "This is not optimized into `bstrpick + slli` because the constant has multiple uses."), so future readers wouldn't have to do archaeology to see them. The code changes LGTM.

Thanks. I have updated https://reviews.llvm.org/D147367 with your suggestion !


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147368/new/

https://reviews.llvm.org/D147368



More information about the llvm-commits mailing list