[PATCH] D147368: [LoongArch] Optimize bitwise and with immediates

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 1 00:33:53 PDT 2023


xen0n added a comment.

I've just found there's no commit message. In general it could be helpful to include one or two short sentences describing the actual change, e.g. "Optimize bitfield extractions retaining bit positions with bstrpick + slli", because "optimize foo" otherwise doesn't carry useful information about the //actual// improvements.



================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1386
+        return SDValue();
+      // Return if the constand can be composed by a single ADDI with
+      // the zero register.
----------------
nit: "constant"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147368/new/

https://reviews.llvm.org/D147368



More information about the llvm-commits mailing list