[PATCH] D147322: [AArch64] Improve fshl cost modeling if 3rd arg is constant.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 06:23:27 PDT 2023


fhahn created this revision.
fhahn added reviewers: dmgreen, ab, t.p.northover, aemerson.
Herald added subscribers: StephenFan, hiraditya, kristof.beyls.
Herald added a project: All.
fhahn requested review of this revision.
Herald added a subscriber: pcwang-thead.
Herald added a project: LLVM.

In that case, the cost for i32 and i64 should be 1 (a single EXTR
instruction). For v4i32 and v2i64 it should be 3 (USHR + SHL + ORR).

Integer types smaller than i32 will get legalized to i32 and share its
cost.

This recovers a SLP regression revealed by D140392 <https://reviews.llvm.org/D140392>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147322

Files:
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/AArch64/fshl.ll
  llvm/test/Transforms/SLPVectorizer/AArch64/fshl.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147322.510009.patch
Type: text/x-patch
Size: 7715 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230331/2ae94223/attachment.bin>


More information about the llvm-commits mailing list