[PATCH] D146728: [utils] Give git a dummy email address when cherry picking.

Roy Sundahl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 15:39:13 PDT 2023


rsundahl added a comment.

In D146728#4218437 <https://reviews.llvm.org/D146728#4218437>, @thetruestblue wrote:

> This is fine... feels a little off. 
> Is there a script to run the docker container? Couldn't we bring it in there or when we build it?
>
> I don't know use case for docker here. Just for tests? Or are we actually using these scripts for a dev environment we might push? Because in that case this feels wrong.

No, it's just a new requirement that doesn't matter when it's being anonymously built in Docker. (This is only a utility function for those interested in Docker builds.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146728/new/

https://reviews.llvm.org/D146728



More information about the llvm-commits mailing list