[PATCH] D146940: [Analysis] Deprecate (Legacy)DivergenceAnalysis

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 04:00:17 PDT 2023


Pierre-vh planned changes to this revision.
Pierre-vh added a comment.

In D146940#4233023 <https://reviews.llvm.org/D146940#4233023>, @arsenm wrote:

> In D146940#4233004 <https://reviews.llvm.org/D146940#4233004>, @Pierre-vh wrote:
>
>> I'd also rather just delete it now - especially because there's no reason not to use UA, but I thought deprecation was a mandatory step.
>
> This isn't major enough to bother deprecating. The only place we might bother with deprecation is really the C API, or long-term migrations in core APIs (e.g. the pointer element type getters)

That makes sense, I agree. Migration is also extremely straightforward for downstream users.
I added a comment on the RFC and will give it a few days in case someone has an objection, in the meantime I'll remove this from review queues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146940/new/

https://reviews.llvm.org/D146940



More information about the llvm-commits mailing list