[PATCH] D143468: [CMake] Remove custom ccache CMake logic

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 17:51:27 PDT 2023


mehdi_amini added a comment.

> My motivation was that people asked to add support for new cache programs (sscache and more)

Seems like this could be supported trivially by having `-DLLVM_CCACHE_BUILD=sscache` for example?\

> I think our build system is way too big and complicated to duplicate functionality that's already in upstream CMake.

I don't see this as a "duplication" right now, but as a convenient **wrapper** on top of the functionality provided by CMake. The code you're deleting illustrates well how non-intrusive the wrapper is actually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143468/new/

https://reviews.llvm.org/D143468



More information about the llvm-commits mailing list