[PATCH] D143468: [CMake] Remove custom ccache CMake logic

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.
Herald added a subscriber: ekilmer.

In D143468#4123606 <https://reviews.llvm.org/D143468#4123606>, @beanz wrote:

> I think getting rid of this option is good for us and our users in the long term.
>
> Looking past the short-term adoption shift, having LLVM's build flows be using features of CMake that work on any CMake project lowers the LLVM-specific learning curve of new contributors.

I don't see how it is applicable here: there is no "LLVM-specific learning" to be applied here, the generic CMake flow will "just work". However it just makes everyone's configuration more cumbersome unnecessarily. I type `-DLLVM_CCACHE_BUILD=ON` directly without thinking about it, similarly for `-DLLVM_ENABLE_LLD=ON`, I wouldn't get the alternatives right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143468/new/

https://reviews.llvm.org/D143468