[PATCH] D146191: [MachineOutliner][MCP][RISCV] Don't run MCP on outlined functions

Tue Mar 28 10:40:07 PDT 2023

paquette added a comment.

In D146191#4227164 <https://reviews.llvm.org/D146191#4227164>, @asb wrote:

> In D146191#4226495 <https://reviews.llvm.org/D146191#4226495>, @pcwang-thead wrote:
>
>> In D146191#4225567 <https://reviews.llvm.org/D146191#4225567>, @craig.topper wrote:
>>
>>> Do the T-Head specific pseudos being expanded need to expanded as late as the other pseudos? Could you have an earlier expansion pass? I was already nervous about the short forward branch instructions being affected before. I know we determined those cases were ok.
>>
>> Yes and thanks, I just tried. They can be placed in `addPreEmitPass()` just like MCP. 
>> Apart from this, do you think it's still worthy marking outlined functions?
>
> For my part, I'd be really interested in @paquette's thoughts on this.

If you mean adding the `IsOutlined` field, I think that it's a good idea. Currently the only way to recognize if a function is outlined is to look at its name, which isn't great. The field is an improvement.

I think it needs a small MIR testcase though. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146191/new/

https://reviews.llvm.org/D146191