[PATCH] D146191: [MachineOutliner][MCP][RISCV] Don't run MCP on outlined functions

Tue Mar 28 05:41:00 PDT 2023

asb added a comment.

In D146191#4226495 <https://reviews.llvm.org/D146191#4226495>, @pcwang-thead wrote:

> In D146191#4225567 <https://reviews.llvm.org/D146191#4225567>, @craig.topper wrote:
>
>> Do the T-Head specific pseudos being expanded need to expanded as late as the other pseudos? Could you have an earlier expansion pass? I was already nervous about the short forward branch instructions being affected before. I know we determined those cases were ok.
>
> Yes and thanks, I just tried. They can be placed in `addPreEmitPass()` just like MCP. 
> Apart from this, do you think it's still worthy marking outlined functions?

For my part, I'd be really interested in @paquette's thoughts on this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146191/new/

https://reviews.llvm.org/D146191