[PATCH] D146169: Non-debuginfo JITLink perf jitdump support
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 27 11:10:52 PDT 2023
lhames added a comment.
Also I've just noticed that `JITLoaderPerf.cpp` (in OrcTargetProcess) depends directly on `llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h` from Orc. That's a layering violation -- the shared types should be moved up into a header in `llvm/ExecutionEngine/Orc/Shared`.
Let me know if you want me to take care of that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146169/new/
https://reviews.llvm.org/D146169
More information about the llvm-commits
mailing list