[PATCH] D146169: Non-debuginfo JITLink perf jitdump support

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Just testing this on Linux and Darwin now.

On Linux it looks good, but I've switch `llvm-jitlink`'s `-perf-support` option to false by default since it's writing unconditionally to the filesystem, which would be surprising default behavior.

On Darwin I'm seeing unused variable warnings due to the `#ifdef __linux__` conditionals. Would it be reasonable to just conditionalize inclusion of that whole file in the TargetProcess library? When it's not included the registration addr will just be unavailable and `PerfSupportPlugin::Create` will error out based on that. Alternatively we could make most of `JITLoaderPerf.cpp` conditional on `#ifdef __linux__` and just have non-linux versions of `registerJITLoaderPerfImpl`, `registerJITLoaderPerfStartImpl`, and `registerJITLoaderPerfEndImpl` that return descriptive errors.

@pchintalapudi -- what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146169/new/

https://reviews.llvm.org/D146169