[PATCH] D146823: [GVN] Avoid replacing uniforms with non-uniforms in propagateEquality

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

In D146823#4223352 <https://reviews.llvm.org/D146823#4223352>, @foad wrote:

> If we're going to do this I think we ought to do it properly, by querying UniformityAnalysis. TTI->isAlwaysUniform will only catch a small fraction of the values that are provably uniform.

I agree, but most targets don't care about uniformity so I don't think we can make GVN depend on UA unless we find a way to avoid running the analysis for those targets. No?
Does UA bail out early for non-GPU targets? (It'd be nice if it did that and just returned an empty UniformityInfo instance for those targets, we could then use UA in more places in the middle-end without worrying about performance)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146823/new/

https://reviews.llvm.org/D146823