[PATCH] D146823: [GVN] Avoid replacing uniforms with non-uniforms in propagateEquality
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 27 02:27:32 PDT 2023
foad added reviewers: AMDGPU, sameerds.
foad added a comment.
If we're going to do this I think we ought to do it properly, by querying UniformityAnalysis. TTI->isAlwaysUniform will only catch a small fraction of the values that are provably uniform.
================
Comment at: llvm/test/Transforms/GVN/uniform-values.ll:1
+; REQUIRES: amdgpu-registered-target
+; RUN: opt < %s -mtriple=amdgcn -passes=gvn -S | FileCheck %s
----------------
Maybe this should go in `test/Transforms/GVN/AMDGPU/`? That's what we've done for lots of other `test/Transforms/*/AMDGPU/` tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146823/new/
https://reviews.llvm.org/D146823
More information about the llvm-commits
mailing list