[PATCH] D146835: [RISCV] Enable usubo formation in CodeGenPrepare.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:499
 
-    return TargetLowering::shouldFormOverflowOp(Opcode, VT, MathUsed);
+    // Pass ISD::UADDO to bypass the default behavior disabling ISD::USUBO.
+    return TargetLowering::shouldFormOverflowOp(ISD::UADDO, VT, MathUsed);
----------------
reames wrote:
> Doesn't this also enable multiply as well?  Do we want to?
You might think that from the name but its never called with ISD::UMULO. I can add an assert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146835/new/

https://reviews.llvm.org/D146835