[PATCH] D146752: [RISCV][RISCVISelLowering] Add tail agnostic policy operand to VECREDUCE instructions

Nitin John Raj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 11:24:36 PDT 2023


nitinjohnraj added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:1998
 let Predicates = [HasVInstructions] in {
-defm : VPatReductionVL<rvv_vecreduce_ADD_vl,  "PseudoVREDSUM", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_UMAX_vl, "PseudoVREDMAXU", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_SMAX_vl, "PseudoVREDMAX", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_UMIN_vl, "PseudoVREDMINU", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_SMIN_vl, "PseudoVREDMIN", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_AND_vl,  "PseudoVREDAND", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_OR_vl,   "PseudoVREDOR", /*is_float*/0>;
-defm : VPatReductionVL<rvv_vecreduce_XOR_vl,  "PseudoVREDXOR", /*is_float*/0>;
+defm : VPatReductionVL_Policy<rvv_vecreduce_ADD_vl,  "PseudoVREDSUM", /*is_float*/0>;
+defm : VPatReductionVL_Policy<rvv_vecreduce_UMAX_vl, "PseudoVREDMAXU", /*is_float*/0>;
----------------
craig.topper wrote:
> ARe there still users of the old `VPatReductionVL` class?
Seems like the answer is no. I've removed it and renamed `VPatReductionVL_Policy` to `VPatReductionVL`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146752/new/

https://reviews.llvm.org/D146752



More information about the llvm-commits mailing list