[PATCH] D146744: [WebAssembly] Redesign DebugValueManager

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:32
   Register CurrentReg;
+  SmallVector<MachineInstr *, 1> getSinkableDebugValues(MachineInstr *Insert);
 
----------------
aheejin wrote:
> dschuff wrote:
> > IIRC `SmallVectorImpl<MachineInstr *>` is preferred over an explicit size for parameters, since any size would work.
> It doesn't compile. But `SmallVector<MachineInstr *>` (without the size parameter) seems to work instead.
oh interesting. out of curiosity I went back and found https://llvm.org/docs/ProgrammersManual.html#llvm-adt-smallvector-h

Maybe it needs to be updated, or maybe return values are different (or maybe default-construction, or operator= or whatever :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146744/new/

https://reviews.llvm.org/D146744