[PATCH] D146744: [WebAssembly] Redesign DebugValueManager

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:32
   Register CurrentReg;
+  SmallVector<MachineInstr *, 1> getSinkableDebugValues(MachineInstr *Insert);
 
----------------
dschuff wrote:
> IIRC `SmallVectorImpl<MachineInstr *>` is preferred over an explicit size for parameters, since any size would work.
It doesn't compile. But `SmallVector<MachineInstr *>` (without the size parameter) seems to work instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146744/new/

https://reviews.llvm.org/D146744