[PATCH] D146544: [llvm-readobj][NFC] Replace size_t in HashHistogram with uint32_t

Junhee Yoo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 17:37:36 PDT 2023


junhee-yoo added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:7181
     DictScope Bucket(W, BucketName);
     W.printNumber("Length", static_cast<uint64_t>(I));
     W.printNumber("Count", static_cast<uint64_t>(Count[I]));
----------------
I guess if the type of `I` is changed from `size_t` to `uint32_t`, `static_cast<uint64_t>` is no longer needed here and on `Count[I]` because `virtual void printNumber(StringRef Label, uint32_t Value)` is exist. How do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146544/new/

https://reviews.llvm.org/D146544



More information about the llvm-commits mailing list