[PATCH] D146544: [llvm-readobj][NFC] Replace size_t in HashHistogram with uint32_t

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 10:06:40 PDT 2023


paulkirth created this revision.
paulkirth added reviewers: jhenderson, junhee-yoo.
Herald added a project: All.
paulkirth requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

Someone ran into an issue with a size_t interface on Darwin.
see (https://reviews.llvm.org/D146492).

Given the use case for HashHistograms, a 32bit unsigned integer should
be sufficient to represent all computed values without overflow.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146544

Files:
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146544.507031.patch
Type: text/x-patch
Size: 7140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230321/278ee2e1/attachment-0001.bin>


More information about the llvm-commits mailing list