[PATCH] D134893: [LSR][TTI][RISCV] Add isAllowTerminatingConditionFoldingAfterLSR into TTI and enable it for RISC-V

EverRest via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 01:18:41 PDT 2023


MarkGoncharovAl added a comment.
Herald added subscribers: jobnoorman, luke.

I think we should start discussion again, because this pass has many changed.

@eopXD 
@JojoR

1. Implemented : https://reviews.llvm.org/D145929

> I saw the patch D132443 <https://reviews.llvm.org/D132443> only support eq/neq condterm, and I want to add gt/lt,
> any suggestion for me

2. Implemented : https://reviews.llvm.org/D136415

> There is a error report as below if i apply this patch on branch main
> error: Terminating value is not safe to expand, need to add it to predicate.

So, may we should rebase this MR and apply changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134893/new/

https://reviews.llvm.org/D134893



More information about the llvm-commits mailing list